Migrate os.path to pathlib.Path in file_processor_handler.py#68758
Merged
Conversation
368f39b to
b795a37
Compare
pierrejeambrun
approved these changes
Jun 23, 2026
fedc00f to
f642c56
Compare
potiuk
reviewed
Jun 29, 2026
a40c67b to
764e55b
Compare
Contributor
Author
|
Thanks @potiuk for the review! I have:
This is now a clean 1-commit PR. Let me know if anything else is needed! |
764e55b to
a1f40cc
Compare
9b0939f to
932e8f7
Compare
os.path to pathlib.Path in file_processor_handler.py932e8f7 to
e20b952
Compare
e20b952 to
300fee0
Compare
Contributor
Author
|
Hey @potiuk as all the things are correct now can you give a quick review |
potiuk
approved these changes
Jul 3, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
The unrelated run_migration_reference.py change is gone — the diff is now a
clean pathlib migration of file_processor_handler.py, and CI is green. Thanks
for splitting it out. LGTM.
This review was drafted by an AI-assisted tool and confirmed by an Airflow
maintainer. The maintainer approving this PR has read the findings and signed
off. If something feels off, please reply on the PR and a maintainer will
follow up.More on how Airflow handles maintainer review:
contributing-docs/05_pull_requests.rst.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #68757
The
airflow.utils.log.file_processor_handlermodule currently relies heavily on theos.pathlibrary for filesystem path manipulations. To modernize the codebase, improve cross-platform readability, and align with modern Python standards, this PR migratesos.pathcalls (e.g.,os.path.join,os.path.abspath,os.path.isdir) to theirpathlib.Pathequivalents where possible.Testing